Update A2A demo to use official @a2a-js/sdk package#22
Merged
Conversation
The demo was using `a2a-js` which is a 3rd party package. This updates the demo to use the official `@a2a-js/sdk` package.
edspencer
reviewed
Jul 8, 2025
| ) | ||
| const { | ||
| metadata, | ||
| contextId: _contextId, |
Contributor
There was a problem hiding this comment.
doesn't appear to be used
Contributor
Author
There was a problem hiding this comment.
Right -- so google's SDK adds a contextId variable on the message upon receive, but we actually dont want to hash with this value there since the client does not have it (so the values will not match). So this pulls it out of the parsedMessage and tags it with an underscore to mark it as unused, but expecetd.
edspencer
reviewed
Jul 8, 2025
edspencer
approved these changes
Jul 8, 2025
Contributor
edspencer
left a comment
edspencer
left a comment
There was a problem hiding this comment.
Couple of small things but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo was using
a2a-jswhich is a 3rd party package. This updates the demo to use the official@a2a-js/sdkpackage.